Backport to branch(3.16) : Fix to avoid deleting non ScalarDB tables when dropping namespaces #3097
+427
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to prevent dropping namespaces that contain any tables (both ScalarDB-managed and non-managed) without explicit force flag, providing clearer error messages to users.
- Adds
deleteMetadata()anddropTable()methods toAdminTestUtilsfor test cleanup - Implements namespace table validation in
JdbcAdminandCosmosAdminbefore dropping - Adds new error code for namespaces with non-ScalarDB tables
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| AdminTestUtils.java | Added abstract methods deleteMetadata() and dropTable() for test utilities |
| DistributedStorageAdminIntegrationTestBase.java | Added integration test for namespace drop validation with non-managed tables |
| JdbcAdminTestBase.java | Added unit tests for namespace drop validation across different database engines |
| CosmosAdminTestBase.java | Added unit test for Cosmos namespace drop validation |
| RdbEngineStrategy.java | Added interface method getTableNamesInNamespaceSql() |
| RdbEngineSqlite.java | Implemented getTableNamesInNamespaceSql() returning null for SQLite |
| RdbEngineSqlServer.java | Implemented SQL query to get table names for SQL Server |
| RdbEnginePostgresql.java | Implemented SQL query to get table names for PostgreSQL |
| RdbEngineOracle.java | Implemented SQL query to get table names for Oracle |
| RdbEngineMysql.java | Implemented SQL query to get table names for MySQL |
| RdbEngineDb2.java | Implemented SQL query to get table names for DB2 |
| JdbcAdmin.java | Added validation logic and getInternalTableNames() helper method |
| CosmosAdmin.java | Added validation logic and getRawTableNames() helper method |
| CoreError.java | Added new error code NAMESPACE_WITH_NON_SCALARDB_TABLES_CANNOT_BE_DROPPED |
| Multiple test utils files | Implemented deleteMetadata() and dropTable() methods for various storage backends |
| Multiple integration test files | Added getAdminTestUtils() method and disabled SQLite/DynamoDB tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated request for a manual backport of the following:
Thank you!